diff -r 3b1da2848fc7 -r d3bac044e0f0 tools/assistant/lib/qhelpdbreader.cpp --- a/tools/assistant/lib/qhelpdbreader.cpp Fri Feb 19 23:40:16 2010 +0200 +++ b/tools/assistant/lib/qhelpdbreader.cpp Fri Mar 12 15:46:37 2010 +0200 @@ -515,7 +515,7 @@ QString QHelpDBReader::mergeList(const QStringList &list) const { QString str; - foreach (QString s, list) + foreach (const QString &s, list) str.append(QLatin1Char('\'') + quote(s) + QLatin1String("\', ")); if (str.endsWith(QLatin1String(", "))) str = str.left(str.length()-2); @@ -567,14 +567,14 @@ bool needUpdate = !m_viewAttributes.count(); - foreach (QString s, attributes) + foreach (const QString &s, attributes) m_viewAttributes.remove(s); if (m_viewAttributes.count() || needUpdate) { m_viewAttributes.clear(); m_indicesCache = indexIds; } - foreach (QString s, attributes) + foreach (const QString &s, attributes) m_viewAttributes.insert(s); m_useAttributesCache = true; return true;